[stable29] fix(caldav): explicitly check from component types - #62899
Closed
backportbot[bot] wants to merge 1 commit into
Closed
[stable29] fix(caldav): explicitly check from component types#62899backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
backportbot
Bot
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
August 4, 2026 16:07
backportbot
Bot
requested review from
ChristophWurst,
SebastianKrupinski,
kesselb and
miaulalala
August 4, 2026 16:07
backportbot
Bot
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // RRULE can be infinate or limited by a UNTIL or COUNT | ||
| if ($component->RRULE) { | ||
| try { | ||
| $rule = new EventReaderRRule($component->RRULE->getValue(), $startDate); |
| } elseif ($component->DUE instanceof \Sabre\VObject\Property\ICalendar\DateTime) { | ||
| // VTODO component types | ||
| $endDate = $component->DUE->getDateTime(); | ||
| } elseif ($component->name === 'VEVENT' && !$component->DTSTART->hasTime()) { |
| } elseif ($component->DUE instanceof \Sabre\VObject\Property\ICalendar\DateTime) { | ||
| // VTODO component types | ||
| $endDate = $component->DUE->getDateTime(); | ||
| } elseif ($component->name === 'VEVENT' && !$component->DTSTART->hasTime()) { |
| } | ||
| // convert dates to timestamp and prevent negative values | ||
| $derived['firstOccurence'] = $startDate ? max(0, $startDate->getTimestamp()) : 0; | ||
| $derived['lastOccurence'] = $endDate ? max(0, $endDate->getTimestamp()) : 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #48131